Fix navbar overflow detection on mobile#138
Merged
MarketDataApp merged 3 commits intomainfrom Mar 6, 2026
Merged
Conversation
The overflow JS was hiding .user-profile-wrapper (inner div) but its parent .user-profile-container (the actual flex item) remained visible, so the login button was never removed from the navbar on mobile.
The overflow utility's ResizeObserver only fires when the container resizes, but async-loaded components (user profile) add content without changing container dimensions. Add a MutationObserver that re-initializes the overflow handler when child nodes change in the navbar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flex-wrap: nowrapon.navbar__innerat all widths so overflow JS can detect flex-item compression on mobile.user-profile-container(flex item) instead of.user-profile-wrapper(inner child)@marketdataapp/uito v2.10.1 which adds:scrollWidth > clientWidthfallback overflow detection (Update limit.md #7)MutationObserverfor async-loaded child content (Merge changes from dev #8)min-widthon user-profile-container to prevent CLS (Merge dev to main #9)Test plan